search

jkrall / analytical

Gem for managing multiple analytics services in your rails app.
MIT License
380 stars 92 forks source link

Module for Reinvigorate. #16

Closed gsiener closed 13 years ago

gsiener commented 13 years ago

We've been using this in production for several months, realized we never issued a pull request.

jkrall commented 13 years ago

This is awesome... thanks a ton for the pull request. I'm embarrassed it took this long to respond.

One note: (other than the one inline note I made above)

In the future, it'd be nice if you could send a pull request without the .gemspec, Rakefile, and VERSION changes. Those aren't very helpful b/c I can't do a simple merge anymore and have to revert those files back to the proper ones from the main branch.

Let's get this reinvigorate question worked out, and then I'll merge these changes in and release a new version. Thanks!

gsiener commented 13 years ago

Hi Joshua:

Great question! I inherited this from a contractor who initially put it together while implementing analytical. Upon review you're absolutely right, so I will update to keep this inline with the api and use track.

Also, sorry about the multiple commits in the pull request -- I'm still getting used to github and didn't realize it wasn't just the module and spec. I will sort this all out and either modify this pull request or close and submit a new one.

Sound good?

jkrall commented 13 years ago

Sounds great! Thanks!

On Jun 29, 2011, at 8:51 AM, gsienerreply@reply.github.com wrote:

Hi Joshua:

Great question! I inherited this from a contractor who initially put it together while implementing analytical. Upon review you're absolutely right, so I will update to keep this inline with the api and use track.

Also, sorry about the multiple commits in the pull request -- I'm still getting used to github and didn't realize it wasn't just the module and spec. I will sort this all out and either modify this pull request or close and submit a new one.

Sound good?

Reply to this email directly or view it on GitHub: https://github.com/jkrall/analytical/pull/16#issuecomment-1467136

gsiener commented 13 years ago

I'll do a new pull request on the branch with just reinvigorate specific changes.