search

jkrall / analytical

Gem for managing multiple analytics services in your rails app.
MIT License
380 stars 92 forks source link

Implement the name_tag method. #27

Closed jellybob closed 12 years ago

jellybob commented 12 years ago

It's a really rough patch, because I'm just hacking something together, but this implements the name_tag method for Mixpanel.

jkrall commented 12 years ago

Hey... thanks for this. Before I merge it in... can you give me a quick explanation of what the name_tag MixPanel method does?

If it's truly a unique-to-MixPanel method, then this is exactly right. But I want to double-check that it's not related to the track() or identify() method instead, because whenever possible the goal is to keep the APIs unified across the different analytics providers.

Thanks!

jellybob commented 12 years ago

It sets the name attached to a user in their UI. Thinking about it passing a :name option to identify would probably make more sense, but it would still need to call name_tag in their JavaScript API. On Oct 17, 2011 7:31 PM, "Joshua Krall" < reply@reply.github.com> wrote:

Hey... thanks for this. Before I merge it in... can you give me a quick explanation of what the name_tag MixPanel method does?

If it's truly a unique-to-MixPanel method, then this is exactly right. But I want to double-check that it's not related to the track() or identify() method instead, because whenever possible the goal is to keep the APIs unified across the different analytics providers.

Thanks!

Reply to this email directly or view it on GitHub: https://github.com/jkrall/analytical/pull/27#issuecomment-2432786

jkrall commented 12 years ago

Ah yeah, that makes sense.

My gut says: have #identify accept an optional :name=>'name' attribute, and then append the call to MixPanel's name_tag function after the existing #identify functionality... does that make sense?

Maybe we should keep this additional #name_tag method but also add the functionality to #identify so that users who don't want to add MixPanel-specific stuff into their analytical calls still get the benefit of name_tag?

If this makes sense... and you have time... go ahead and add this functionality to this commit, and I'll gladly merge this in. Thanks!

On Mon, Oct 17, 2011 at 1:34 PM, Jon Wood < reply@reply.github.com>wrote:

It sets the name attached to a user in their UI. Thinking about it passing a :name option to identify would probably make more sense, but it would still need to call name_tag in their JavaScript API. On Oct 17, 2011 7:31 PM, "Joshua Krall" < reply@reply.github.com> wrote:

Hey... thanks for this. Before I merge it in... can you give me a quick explanation of what the name_tag MixPanel method does?

If it's truly a unique-to-MixPanel method, then this is exactly right. But I want to double-check that it's not related to the track() or identify() method instead, because whenever possible the goal is to keep the APIs unified across the different analytics providers.

Thanks!

Reply to this email directly or view it on GitHub: https://github.com/jkrall/analytical/pull/27#issuecomment-2432786

Reply to this email directly or view it on GitHub: https://github.com/jkrall/analytical/pull/27#issuecomment-2432830

jkrall commented 12 years ago

Closing this one, because it was handled here: https://github.com/jkrall/analytical/pull/31