jkrall / analytical

Gem for managing multiple analytics services in your rails app.
MIT License
380 stars 92 forks source link

Rails 3.1 fix doesn't work in Rails 3.2 #33

Closed nirvdrum closed 12 years ago

nirvdrum commented 12 years ago

In lib/analytical/api.rb there is a check for Rails 3.1 like so: if ::Rails::VERSION =~ /^3\.1/

The same Rails 3.1 codepath should probably be run for all versions > 3.1, but the check as it is will only work with 3.1.x. So Rails 3.2 executes the old path and raises a bunch of deprecation warnings.