Fixed the Rails version check.

jkrall / analytical

Gem for managing multiple analytics services in your rails app.

MIT License

380 stars 92 forks source link

Fixed the Rails version check. #35

Closed nirvdrum closed 12 years ago

nirvdrum commented 12 years ago

The current version check is:

::Rails::VERSION::STRING.to_i >= 3.1

This fails because an integer has no decimal portion. Changing the to_i to to_f would work in this case, but it'll similarly lose the patch level portion of the version number. The check I'm doing in this pull request uses the same version comparison API that RubyGems uses itself.

jkrall commented 12 years ago

Wow, that's pretty embarrassing. Thanks for the patch! :)