search

jkrall / analytical

Gem for managing multiple analytics services in your rails app.
MIT License
381 stars 93 forks source link

update kiss metrics script #57

Closed yzhang closed 11 years ago

yzhang commented 11 years ago

seems kiss metrics script is outdated, and here's the updated one.

clickonchris commented 11 years ago

I had gotten KM working with analytical a few weeks ago by configuring my js_url_key to be

'//doug1izaerwt3.cloudfront.net/my-km-key.1.js'

If this change gets integrated I would need to update my js_url_key to be

'my-km-key'

Just an observation - it could be useful as part of some upgrade notes

freerobby commented 11 years ago

@yzhang Thanks for the PR. I don't want to merge this into master, which is used for minor/point releases, because as @clickonchris explained it will break tracking for users who are expecting the current behavior. I see two options moving forward:

1) Keep this PR open, and merge it into the next major release of analytical. 2) Add logic to the gem that checks for the format of my-km-key and gsub away the URL characters if needed.

sfsekaran commented 11 years ago

Could you modify the config to detect and work both ways? I see no reason why it should not allow people to choose whichever way they want, at least for now.

sfsekaran commented 11 years ago

I'm going to close this pull request for now, it's been lingering for quite a while. Please resubmit after it's backwards compatible :+1: