jkrall / analytical

Gem for managing multiple analytics services in your rails app.
MIT License
381 stars 93 forks source link

Differences between gem and source #60

Closed gyarra closed 11 years ago

gyarra commented 11 years ago

Hi,

I noticed some differences between the code in the gem and the code on Github. It appears that the gem code is more current, although both say they are version 3.0.12. I'm happy to merge in code from the gem that seems more up to date.

modules/mixpanel.rb

3 differences

modules/google.rb

2 differences

api.rb

3 differences.

Just say the word and I'm happy to jump in.

Thanks! Gabe

gyarra commented 11 years ago

Never mind, I was wrong about which code is more up to date. The code in git is more recent.

Having said that, I think the version number in the github source should be incremented to show that this code is for the next release. Perhaps that sounds pedantic, but it would have made things more clear to me.


The reason this was an issue for me is I was trying to monkey-patch the MixPanel module. It didn't work because the library name is "mpmetrics" in the gem, but it's "mixpanel" in the current code-base. I was using the code-base as an example to work from.