search

jkrall / analytical

Gem for managing multiple analytics services in your rails app.
MIT License
381 stars 93 forks source link

Add Mixpanel#person and Mixpanel#revenue methods #73

Closed clupprich closed 11 years ago

clupprich commented 11 years ago

Adds the new Mixpanel revenue functionality and allows setting of people attributes. Includes specs :)

sfsekaran commented 11 years ago

Would it be too much trouble to have you make the analytical option the exact same name as the mixpanel option? I.e. instead of :track, it would be :track_pageviews? I realize this is a small change, but I feel it's important to reduce synonymic confusion between the two systems. I'm willing to be argued with if you disagree. Other than that, I see no problem merging this request.

clupprich commented 11 years ago

Sure, I will amend my pull request!

sfsekaran commented 11 years ago

You know what? I'll do it myself. No need to bother you further :). Thanks for the pull request!

clupprich commented 11 years ago

I'm confused ;). The reason I did this pull request is that we want to use less data points but the default behaviour was set to track pageviews. I left it that way and just introduced the posibility to disable it.

clupprich commented 11 years ago

See here: https://mixpanel.com/docs/integration-libraries/javascript-full-api#track_pageview (although the Mixpanel documentation is quite confusing these days because they currently serve two types of documentation)

sfsekaran commented 11 years ago

Christoph, thanks for clearing this up. It's definitely a bit confusing.

I'll pull the other commits in now, it now makes total sense to me why you implemented it. A default of true is good because, like you said, that's their default.

Thanks again! Help is always, always appreciated.

On Monday, July 1, 2013 at 12:49 PM, Christoph Lupprich wrote:

See here: https://mixpanel.com/docs/integration-libraries/javascript-full-api#track_pageview (although the Mixpanel documentation is quite confusing these days because they currently serve two types of documentation)

— Reply to this email directly or view it on GitHub (https://github.com/jkrall/analytical/pull/73#issuecomment-20305709).