search

jkriege2 / JKQtPlotter

an extensive Qt5 & Qt6 Plotter framework (including a feature-richt plotter widget, a speed-optimized, but limited variant and a LaTeX equation renderer!), written fully in C/C++ and without external dependencies
http://jkriege2.github.io/JKQtPlotter/index.html
GNU Lesser General Public License v2.1
889 stars 190 forks source link

Create v4.0.1 tag? #113

Closed arBalasquide closed 10 months ago

arBalasquide commented 10 months ago

v4.0.0 has a typo in the CMake, which was fixed in a later commit, that caused some includes to be missing on an install. Would be nice to bump the release so others don't go to v4.0.0 and waste time figuring out why their build isn't working.

Thanks!

jkriege2 commented 10 months ago

Do you remember which fixes are neccesarry? Otherwise I'm hoping to make a new 5.0.0 release soon!

arBalasquide commented 10 months ago

Yes, it was a typo https://github.com/jkriege2/JKQtPlotter/blob/d45083ee9bdd96de1a381ad0d63c4ba8ef547e5c/lib/jkqtplotter/CMakeLists.txt#L310

It should be HEADERS_BASE. Already fixed in a later commit, but causes build issues in the 4.0.0 release. If a new release is coming soon anyhow, then its no big deal.

jkriege2 commented 10 months ago

https://github.com/jkriege2/JKQtPlotter/releases/tag/v4.0.1 should fix the bug!