search

jkriege2 / JKQtPlotter

an extensive Qt5 & Qt6 Plotter framework (including a feature-richt plotter widget, a speed-optimized, but limited variant and a LaTeX equation renderer!), written fully in C/C++ and without external dependencies
http://jkriege2.github.io/JKQtPlotter/index.html
GNU Lesser General Public License v2.1
889 stars 190 forks source link

Crash in 4.0.2 #123

Closed doug1234 closed 8 months ago

doug1234 commented 9 months ago

The function JKQTMathTextFontSpecifier JKQTMathTextFontSpecifier::getAppFontSFFamilies() crashes if it gets called in 4.0.2. This is due to a missing variable definition. Looks like it has been fixed in master. Should there be a 4.0.3?

jkriege2 commented 8 months ago

Hmmm ... it seems that went pear-shaped ... 4.0.2 seems not to be a tag onto the 4.0.0. branch, but I erroneously tagged the master .... so that function was never meant to be in that tag.

I think I will have to think about starting to tag 5.0.0 version ... I got a lot of the features that I wished for that release by now ...

Until I can create a 5.0.0 branch ... could you work with master?

doug1234 commented 8 months ago

Maybe I should just use the 4.0.1 tag then. Should that one be safe?

jkriege2 commented 8 months ago

If you don't need this fix: https://github.com/jkriege2/JKQtPlotter/pull/115 you can use 4.0.1

jkriege2 commented 8 months ago

BTW: Which part of JKQTPlotter do you use?

doug1234 commented 8 months ago

I really just use the basic stuff. I don't think that fix is necessary. I could wait for 5.0 to update.

jkriege2 commented 8 months ago

I just added a release v4.0.3 which should again be on the correct 4.0.0 branch ... does this help (unless you use the more feature-rich 5.0/master anyways)

doug1234 commented 8 months ago

Thanks. Will start using that version shortly.