search

jkriege2 / JKQtPlotter

an extensive Qt5 & Qt6 Plotter framework (including a feature-richt plotter widget, a speed-optimized, but limited variant and a LaTeX equation renderer!), written fully in C/C++ and without external dependencies
http://jkriege2.github.io/JKQtPlotter/index.html
GNU Lesser General Public License v2.1
889 stars 190 forks source link

Image output scaling #96

Closed nmielcarek closed 1 year ago

nmielcarek commented 1 year ago

Greetings,

I'm curious why this 1.1 scaling factor exists here in JKQTBasePlotter::saveAsPixelImage: https://github.com/jkriege2/JKQtPlotter/blob/master/lib/jkqtplotter/jkqtpbaseplotter.cpp#L4002

Whenever I try to save a png image, it always creates an empty transparent region around the plot due to that extra scaling which isn't desired.

OS: Linux (Fedora 36)

Thanks for the great library! -Nathan

jkriege2 commented 1 year ago

Hmmm ... I think that's a remenant of (very?) old code ... I will look into this. Basically I agree that this is unneccesary.

PS: Sory fpr the late answer!

jkriege2 commented 1 year ago

fixed via https://github.com/jkriege2/JKQtPlotter/commit/d23ea0a79ebeddd1d63e4f1ea138de1192e6a9f6