search

jkroepke / 2Moons

Open Source Browsergame Framework
MIT License
152 stars 112 forks source link

English Translation is incorrect. #75

Open korhaldragonir opened 8 years ago

korhaldragonir commented 8 years ago

Hi Jan,

The english translation is terribly off. I am currently in the process of redoing the entire English Language files on a Fork of the project. When done I will send in the Patch.

jkroepke commented 8 years ago

Hi!

Translations contributed by the community over years, because my english is tribble, too.

Only the German Translation was written by myself.

Tip: If you have questions or you do not understand how it works somethink, feel free to ask here, Otherwise, the OGame Wiki is a good source of informations: http://ogame.wikia.com/wiki/Main_Page

korhaldragonir commented 8 years ago

Hi,

Thanks for the information and the links. I have fixed the Public file and am nearly done with the InGame file. I will of course check how all looks in the game and correct where necessary.

When all checks out I will send in the Patch.

jkroepke commented 8 years ago

Patches? We are on github! It will be better to use pull request. Checkout https://help.github.com/articles/using-pull-requests/

korhaldragonir commented 8 years ago

It is not possible to submit pull requests from GitLab to GitHub. At least not for as far as I know. I will try to submit a pull request, but send a patch if Pull Requests won't work.

jkroepke commented 8 years ago

Ah.

i don't know that you are using a private repo mangement.

korhaldragonir commented 8 years ago

Making steady progress on the translation. Currently double checking if the sentences ingame are still making sense is taking up the most time.

jkroepke commented 8 years ago

Thank you for your updates.

korhaldragonir commented 8 years ago

First of all my apologies for being so inactive of late. Things are very busy at work so I nearly have no moments to spare. Just wanted to let you know that I am still working on the translations, however they take longer than I would have wanted.

abraxas86 commented 8 years ago

Korhaldragonir: how can I grab your translations? I just installed the game (and am checking it out) for the first time today but saw a few areas that needed corrections still.

korhaldragonir commented 8 years ago

It is still a work in progress but let me make an export from my GitLab for you. I will try to have it ready for you by tomorrow evening.

abraxas86 commented 8 years ago

Thanks! No rush on it - just drop another message when it's up if you remember. :)

korhaldragonir commented 8 years ago

Here it is, I have simply zipped the en directory that is located under the language directory.

Keep in mind it is still a work in progress so there will still be some errors in there. en.zip

abraxas86 commented 8 years ago

Thanks! Updating my game now. :)

abraxas86 commented 8 years ago

Looks like the patch doesn't apply everywhere - for example, the links down the left show the old names on the "Overview" page, but if you flip to the "Famous Battles" page, they update (ie: hangar becomes shipyard, officers becomes DM Shop, etc).

I'd like to help contribute to this patch when I get some time at home.

jkroepke commented 8 years ago

You have the clear the cache.

wardrich notifications@github.com<mailto:notifications@github.com> schrieb am Mo., 6. Juni 2016, 17:51:

Looks like the patch doesn't apply everywhere - for example, the links down the left show the old names on the "Overview" page, but if you flip to the "Famous Battles" page, they update (ie: hangar becomes shipyard, officers becomes DM Shop, etc).

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/jkroepke/2Moons/issues/75#issuecomment-224001294, or mute the threadhttps://github.com/notifications/unsubscribe/ABfQC7fG6Rcr65-O-WSTblwSSJa5MnGIks5qJEHagaJpZM4GUfYU.

abraxas86 commented 8 years ago

That doesn't seem to be the issue. I wiped out the original /language/en directory with the one provided. I've tried clearing the cache, going in private mode, and using another browser that I have never accessed the game from. I'll look further into it when I get home.

On an off-note, I'm new to Git - is this the right place to be discussing the patch? I don't want to leave a mess behind if there's a better way to go about it.

jkroepke commented 8 years ago

You have to clear the server cache at the admin panel. ;-)

To discuss about quallity or error in the translation, See #207

wardrich notifications@github.com<mailto:notifications@github.com> schrieb am Mo., 6. Juni 2016, 18:19:

That doesn't seem to be the issue. I wiped out the original /language/en directory with the one provided. I've tried clearing the cache, going in private mode, and using another browser that I have never accessed the game from. I'll look further into it when I get home.

On an off-note, I'm new to Git - is this the right place to be discussing the patch? I don't want to leave a mess behind if there's a better way to go about it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/jkroepke/2Moons/issues/75#issuecomment-224009058, or mute the threadhttps://github.com/notifications/unsubscribe/ABfQC5wQYPoz2DZM7ltT8UcSZvn0XttAks5qJEhggaJpZM4GUfYU.

abraxas86 commented 8 years ago

D'oh! Thanks :) Clearing server cache fixed it right up. Thanks!

terassiel commented 7 years ago

Also did a complete rework of the english files, including a new FAQ that actualy makes sense and isnt based on ogame but rather 2moons behaviour. Please remember to adjust all values accordingly to your game en.zip And a rework for german: de.zip

These are files for a retro universe and dont include any non stock ships, but i also have one for all ships if you guys prefer that.