jkroepke / helm-secrets

A helm plugin that help manage secrets with Git workflow and store them anywhere
https://github.com/jkroepke/helm-secrets/wiki
Apache License 2.0
1.53k stars 129 forks source link

Add HELM_SECRETS_DECRYPT_SECRETS_IN_TMP_DIR #390

Closed jkroepke closed 1 year ago

jkroepke commented 1 year ago

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #381

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.22% :warning:

Comparison is base (58b1461) 86.89% compared to head (14485d2) 86.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #390 +/- ## ========================================== - Coverage 86.89% 86.67% -0.22% ========================================== Files 23 23 Lines 824 833 +9 ========================================== + Hits 716 722 +6 - Misses 108 111 +3 ``` | [Files Changed](https://app.codecov.io/gh/jkroepke/helm-secrets/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan-Otto+Kr%C3%B6pke) | Coverage Δ | | |---|---|---| | [scripts/run.sh](https://app.codecov.io/gh/jkroepke/helm-secrets/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan-Otto+Kr%C3%B6pke#diff-c2NyaXB0cy9ydW4uc2g=) | `87.90% <50.00%> (-1.93%)` | :arrow_down: | | [scripts/commands/help.sh](https://app.codecov.io/gh/jkroepke/helm-secrets/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan-Otto+Kr%C3%B6pke#diff-c2NyaXB0cy9jb21tYW5kcy9oZWxwLnNo) | `100.00% <100.00%> (ø)` | | | [scripts/lib/file.sh](https://app.codecov.io/gh/jkroepke/helm-secrets/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jan-Otto+Kr%C3%B6pke#diff-c2NyaXB0cy9saWIvZmlsZS5zaA==) | `85.00% <100.00%> (+0.78%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 year ago

sh-checker report

To get the full details, please check in the job output.

shellcheck errors ``` 'shellcheck -x' returned error 1 finding the following syntactical issues: ---------- In tests/unit/template.bats line 2058: run env HELM_SECRETS_DECRYPT_SECRETS_IN_TMP_DIR=true WSLENV="HELM_SECRETS_DECRYPT_SECRETS_IN_TMP_DIR:${WSLENV}" \ ^-------^ SC2031 (info): WSLENV was modified in a subshell. That change might be lost. For more information: https://www.shellcheck.net/wiki/SC2031 -- WSLENV was modified in a subshell... ---------- You can address the above issues in one of three ways: 1. Manually correct the issue in the offending shell script; 2. Disable specific issues by adding the comment: # shellcheck disable=NNNN above the line that contains the issue, where NNNN is the error code; 3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file. ```
shfmt errors ``` 'shfmt ' found no issues. ```