Closed jeliebig closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
402de1e
) 86.56% compared to head (7f90153
) 86.56%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looking forward to testing the feature!
At the moment, I have no clue, why IT tests with coverage are failing.
At the moment, I have no clue, why IT tests with coverage are failing.
Could that be caused by me changing things in the test libraries?
Hmmm, now it seems there is a problem with uploading a new report?
What this PR does / why we need it:
This PR adds the 1Password CLI as an additional custom backend.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #424Special notes for your reviewer:
I really wanted to make the tests work as well, but for some reason
op
always thinks it is not authenticated. Manually running the decrypt function with the test file does work as expected. I tried a few things to make this work with BATS:~/.config/op
was copied to${HOME}/.config/op
withinsetup_suite.bash
--session
parameter ofop
op
withinsetup_suite.bash
doesn't work, sinceop
reports it is not signed in during the test run anywayIf you don't have an idea on how to potentially fix this and don't want to keep some manual test instructions for this I'll remove that commit again.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR