jkroepke / helm-secrets

A helm plugin that help manage secrets with Git workflow and store them anywhere
https://github.com/jkroepke/helm-secrets/wiki
Apache License 2.0
1.53k stars 129 forks source link

Add the 1Password CLI as a custom backend #431

Closed jeliebig closed 9 months ago

jeliebig commented 10 months ago

What this PR does / why we need it:

This PR adds the 1Password CLI as an additional custom backend.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #424

Special notes for your reviewer:

I really wanted to make the tests work as well, but for some reason op always thinks it is not authenticated. Manually running the decrypt function with the test file does work as expected. I tried a few things to make this work with BATS:

If you don't have an idea on how to potentially fix this and don't want to keep some manual test instructions for this I'll remove that commit again.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (402de1e) 86.56% compared to head (7f90153) 86.56%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #431 +/- ## ======================================= Coverage 86.56% 86.56% ======================================= Files 23 23 Lines 856 856 ======================================= Hits 741 741 Misses 115 115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bilby91 commented 9 months ago

Looking forward to testing the feature!

jkroepke commented 9 months ago

At the moment, I have no clue, why IT tests with coverage are failing.

jeliebig commented 9 months ago

At the moment, I have no clue, why IT tests with coverage are failing.

Could that be caused by me changing things in the test libraries?

jeliebig commented 9 months ago

Hmmm, now it seems there is a problem with uploading a new report?