search

jkroepke / helm-secrets

A helm plugin that help manage secrets with Git workflow and store them anywhere
https://github.com/jkroepke/helm-secrets/wiki
Apache License 2.0
1.53k stars 129 forks source link

Update ArgoCD Integration.md #454

Closed vainkop closed 5 months ago

vainkop commented 5 months ago
  1. Update the doc since it is possible to use helm secrets in Argo CD for external Charts.
  2. sops backend was tested & is working.

What this PR does / why we need it: Update the doc since it is possible to use helm secrets in Argo CD for external Charts & the solution is in the same ArgoCD Integration.md here

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.56%. Comparing base (c6888be) to head (0ad78a2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #454 +/- ## ======================================= Coverage 86.56% 86.56% ======================================= Files 23 23 Lines 856 856 ======================================= Hits 741 741 Misses 115 115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jkroepke commented 5 months ago

Good to hear this.

I guess, if it works, we can also remove the BETA from the headline? What did you mean?

vainkop commented 5 months ago

Good to hear this.

I guess, if it works, we can also remove the BETA from the headline? What did you mean?

It works with sops 3.8.1 + ArgoCD 3.11.3 + AWS KMS but I haven't tested it against other providers & methods.