search

jkroso / atom-browser-refresh-on-save

A plugin for Atom which reloads assets in the browser as soon as you save them
7 stars 3 forks source link

added support for Firefox and FirefoxDeveloperEdition #16

Closed JamesDBartlett3 closed 4 years ago

JamesDBartlett3 commented 6 years ago

I just threw this together for kicks - it's my first attempt at writing Atom package code.

Compared to your Chrome/Canary refresh scripts, mine for Firefox/DeveloperEdition are a little rough around the edges, and not very flexible. If I end up with more spare time later today or tomorrow, I might see if I can make them a bit more robust & versatile...

Anyway, I'd love to hear what you think of my changes whenever you have a free moment. No rush whatsoever. Cheers!

jkroso commented 6 years ago

Looks okay. I can't merge it with the edit to the package.json file though. And I haven't tested it but it looks like it would focus the firefox browser every time you save which would be annoying.

JamesDBartlett3 commented 6 years ago

Fair enough. Well, I guess it's back to the drawing board for me! Thanks for the feedback.

On Mon, Jun 4, 2018, 03:31 Jake Rosoman notifications@github.com wrote:

Looks okay. I can't merge it with the edit to the package.json file though. And I haven't tested it but it looks like it would focus the firefox browser every time you save which would be annoying.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jkroso/atom-browser-refresh-on-save/pull/16#issuecomment-394275807, or mute the thread https://github.com/notifications/unsubscribe-auth/AjwSbM-4K8reJSeA5TDysgrUQrsBAMF8ks5t5PB-gaJpZM4UYMy4 .