search

jkrumbiegel / GridLayoutBase.jl

MIT License
4 stars 13 forks source link

remove unbound type parameter #44

Closed nsajko closed 2 years ago

nsajko commented 2 years ago

Unbound type parameters often cause performance issues and run time dispatch.

Issue found using https://github.com/JuliaLang/julia/pull/46608

codecov-commenter commented 2 years ago

Codecov Report

Merging #44 (a1e9c61) into master (42bda73) will decrease coverage by 0.36%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   91.42%   91.05%   -0.37%     
==========================================
  Files           6        6              
  Lines        1387     1387              
==========================================
- Hits         1268     1263       -5     
- Misses        119      124       +5
Impacted Files Coverage Δ
src/layoutobservables.jl 82.84% <ø> (ø)
src/helpers.jl 77.50% <0.00%> (-1.25%) :arrow_down:
src/gridlayout.jl 93.22% <0.00%> (-0.39%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jkrumbiegel commented 2 years ago

Thanks!