jku-vds-lab / dashboard-onboarding

0 stars 0 forks source link

Group position when building up a traversal is not correct #132

Open VanessaFediuk opened 11 months ago

VanessaFediuk commented 11 months ago

When a Story is built up in the editor(when selecting a traversal strategy from the drop-down or when building the initial traversal when opening the editor) the position of the group nodes and of the nodes inside of a group are not correct. The screenshot shows that for the depth-first traversal. Seems like the position of groups and nodes inside of groups is handled like the groups would be a default node. Child nodes are positioned on top of each other(they are all there but only one can be seen on the screenshot). The edge is not connected with the Group node but to one of its children.

Image

This was working before the new saving method was used. Now the following useEffect function is called before the changes the buildTraversal function was called. parts of the build Traversal might help to make this work. useEffect(() => { props.setNodesForSave(nodes); props.setEdgesForSave(edges); const tOrder = new TraversalOrder(edges, nodes); tOrder.createTraversal(); }, [nodes, props, edges]);

VanessaFediuk commented 11 months ago

Position of nodes is fixed. Edges need to be handled next.