Fixes for issues found during demo dry run

jku / repository-playground

Community artifact repository workflow experiments

Other

7 stars 4 forks source link

Fixes for issues found during demo dry run #123

Closed jku closed 1 year ago

jku commented 1 year ago

@lukas: I think these both make sense to merge, assuming we can still do a dry-run tomorrow to make sure it all works.

Changes are:

signer: Don't ask for a signature if there are invites to delegated roles (this was a regression that happened when I changed when signing happens: the test input was wrong too, otherwise we would have noticed)
signing event: don't say "TODO"

jku commented 1 year ago

Iirc, root metadata is first created - at this point root is added to unsigned (because user could sign it). A little later a targets signer is invited: this makes root not signable anymore (because we know there will be more changes)...

It's possible that another order of operations would remove the need to do this tracking