search

jkuchar / MultipleFileUpload

Upload more files at once using Nette Forms. More front-end interfaces available. (fallback between them is available)
http://addons.nette.org/cs/multiplefileupload
BSD 3-Clause "New" or "Revised" License
10 stars 11 forks source link

Remove code duplicities in JavaScript in User Interfaces #27

Open jkuchar opened 10 years ago

jkuchar commented 10 years ago

Code duplicity is always wrong. And here it looks like huge whole class is copied into each interface.

Ciki commented 10 years ago

where exactly?

jkuchar commented 10 years ago

Look at this commit, there is the same code 3 times. :-)

https://github.com/jkuchar/MultipleFileUpload/commit/d00682d7f73e71b4b2b8c17586fe436157374ef5

Lines: https://github.com/jkuchar/MultipleFileUpload/commit/d00682d7f73e71b4b2b8c17586fe436157374ef5#diff-b00949811c8f0921e4f29077c76e2912R1 https://github.com/jkuchar/MultipleFileUpload/commit/d00682d7f73e71b4b2b8c17586fe436157374ef5#diff-64b783938728936db12d11275364ee4aR8 https://github.com/jkuchar/MultipleFileUpload/commit/d00682d7f73e71b4b2b8c17586fe436157374ef5#diff-3799f06dcf41d845e9d975c3e2bdfb30R9

Ciki commented 10 years ago

aah, sure. the part commented as 'COMMON CODEBASE FOR ALL INTERFACES' .. It should be refactored for sure... :)