search

jkudish / JigoShop-Software-Add-on

Add functionality to the JigoShop WordPress plugin, which allows you to run a full-blown software shop, including license activation, license retrieval, activation e-mails and more
https://github.com/jkudish/JigoShop-Software-Add-on
19 stars 2 forks source link

Lost License Form Sends Email With Bad Email #3

Closed johnwu closed 13 years ago

johnwu commented 13 years ago

If I enter an email address that does not have any purchases, it currently sends an email. It should just display a message on the web page that no purchases were found. Also noticed that after pressing the "Email Now", the busy indicator just spins - would it be possible to display "Orders have been emailed to you at {email}" for success and "No purchases found" on failure?

jkudish commented 13 years ago

This shouldn't happen, and I can't seem to duplicate it on my own server, is this on your server?

johnwu commented 13 years ago

Yes, http://secure.sparkbooth.com/store/lost-license/

On Mon, Aug 22, 2011 at 10:45 AM, jkudish reply@reply.github.com wrote:

This shouldn't happen, and I can't seem to duplicate it on my own server, is this on your server?

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872467

jkudish commented 13 years ago

Is this not what you see when you enter an invalid email address? https://skitch.com/e-jkudish/f1wdu/lost-license-sparkbooth

johnwu commented 13 years ago

That is perfect! But I am not seeing that on my server.

On Mon, Aug 22, 2011 at 10:50 AM, jkudish reply@reply.github.com wrote:

Is this not what you see when you enter an invalid email address? https://skitch.com/e-jkudish/f1wdu/lost-license-sparkbooth

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872513

jkudish commented 13 years ago

That screenshot was taken on your server!!!

On 2011-08-22, at 10:51 AM, johnwu wrote:

That is perfect! But I am not seeing that on my server.

On Mon, Aug 22, 2011 at 10:50 AM, jkudish reply@reply.github.com wrote:

Is this not what you see when you enter an invalid email address? https://skitch.com/e-jkudish/f1wdu/lost-license-sparkbooth

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872513

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872522

jkudish commented 13 years ago

are you using chrome or firefox? can you see if any errors show up in the console when it fails for you?

johnwu commented 13 years ago

oh, I see I used XXXX@XXXXX.com, and there are orders that have not completed yet.

On Aug 22, 2011, at 10:52 AM, jkudishreply@reply.github.com wrote:

That screenshot was taken on your server!!!

On 2011-08-22, at 10:51 AM, johnwu wrote:

That is perfect! But I am not seeing that on my server.

On Mon, Aug 22, 2011 at 10:50 AM, jkudish reply@reply.github.com wrote:

Is this not what you see when you enter an invalid email address? https://skitch.com/e-jkudish/f1wdu/lost-license-sparkbooth

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872513

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872522

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872527

johnwu commented 13 years ago

I am using chrome

On Aug 22, 2011, at 10:54 AM, jkudishreply@reply.github.com wrote:

are you using chrome or firefox? can you see if any errors show up in the console when it fails for you?

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872552

jkudish commented 13 years ago

oh, I see I used XXXX@XXXXX.com, and there are orders that have not completed yet.

That may be the key to the issue here. I may have forgotten to put a condition for incomplete sales in the code that handles that part.

johnwu commented 13 years ago

Ok, if I use an email that has no orders, then it I get the no orders found message. It is just XXXX@XXXXX.com, any ideas why my orders are incomplete?

jkudish commented 13 years ago

I am looking into this issue now

jkudish commented 13 years ago

Did you return to the site after completing the payment with paypal?

johnwu commented 13 years ago

Yes, that happened with the last purchase. But that order is in "processing" state

On Mon, Aug 22, 2011 at 11:06 AM, jkudish reply@reply.github.com wrote:

Did you return to the site after completing the payment with paypal?

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872653

jkudish commented 13 years ago

Did you pay with echeck?

On 2011-08-22, at 11:08 AM, johnwu wrote:

Yes, that happened with the last purchase. But that order is in "processing" state

On Mon, Aug 22, 2011 at 11:06 AM, jkudish reply@reply.github.com wrote:

Did you return to the site after completing the payment with paypal?

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872653

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872663

johnwu commented 13 years ago

Here is the test product I used

http://secure.sparkbooth.com/store/buy-sparkbooth/test-product/

It is hooked into my real account.

johnwu commented 13 years ago

I disabled eCheck, but for that order I used PayPal Smart Connect. I just did 2 another order using Instant Transfer and Credit Card, and they are in processing state too. Maybe for the lost license key, we need to have send out orders in processing state too.

On Mon, Aug 22, 2011 at 11:08 AM, jkudish reply@reply.github.com wrote:

Did you pay with echeck?

On 2011-08-22, at 11:08 AM, johnwu wrote:

Yes, that happened with the last purchase. But that order is in "processing" state

On Mon, Aug 22, 2011 at 11:06 AM, jkudish reply@reply.github.com wrote:

Did you return to the site after completing the payment with paypal?

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872653

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872663

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872665

jkudish commented 13 years ago

I just made a test purchase. Can you please refund me the $1 when you get a chance :)

I experienced the same thing as you. It seems for some reason the Paypal IPN isn't catching the transaction, even though it did on my previous tests on my server. Again, something I need to look into further

Maybe for the lost license key, we need to have send out orders in processing state too.

No, that may be a bad idea if, for example, someone doesn't complete the sale at all and just walk away. I will fix the issue :)

johnwu commented 13 years ago

Do I need to do something in my PayPal account for IPN? Or is Jigoshop passing the IPN callback url automatically?

On Mon, Aug 22, 2011 at 11:16 AM, jkudish reply@reply.github.com wrote:

I just made a test purchase. Can you please refund me the $1 when you get a chance :)

I experienced the same thing as you. It seems for some reason the Paypal IPN isn't catching the transaction, even though it did on my previous tests on my server. Again, something I need to look into further

Maybe for the lost license key, we need to have send out orders in processing state too.

No, that may be a bad idea if, for example, someone doesn't complete the sale at all and just walk away. I will fix the issue :)

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872740

jkudish commented 13 years ago

It should all be automatic

On 2011-08-22, at 11:17 AM, johnwu wrote:

Do I need to do something in my PayPal account for IPN? Or is Jigoshop passing the IPN callback url automatically?

On Mon, Aug 22, 2011 at 11:16 AM, jkudish reply@reply.github.com wrote:

I just made a test purchase. Can you please refund me the $1 when you get a chance :)

I experienced the same thing as you. It seems for some reason the Paypal IPN isn't catching the transaction, even though it did on my previous tests on my server. Again, something I need to look into further

Maybe for the lost license key, we need to have send out orders in processing state too.

No, that may be a bad idea if, for example, someone doesn't complete the sale at all and just walk away. I will fix the issue :)

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872740

Reply to this email directly or view it on GitHub: https://github.com/jkudish/JigoShop-Software-Add-on/issues/3#issuecomment-1872755