search

jkuester / unlauncher

Android minimalistic launcher
https://jkuester.github.io/unlauncher/
MIT License
306 stars 47 forks source link

Adds search field options #143

Closed hayribakici closed 9 months ago

hayribakici commented 1 year ago

Fixes #62, fixes #43. This PR adds an additional option screen to hide and position the search field in the app drawer. Since the 'show keyboard' toggle is also part of this, it is grouped together with this new option (see screenshots). Once the 'Show search field' switch is turned off, the show keyboard option and positioning the search field are disabled.

On a technical level, I had to upgrade protobuf to (the current) version 3.23, since the current version had problems wish the optional property.

I am also thinking to add a 'Reset to default' action for this screen. What do you think @jkuester ?

hayribakici commented 1 year ago

Returning to draft, because I found a bug with Android L

hayribakici commented 9 months ago

@jkuester #138 fixes the textColor of the SwitchCompat buttons. This should also be applied in the new screens here. Should a new PR be created?

TobiTenno commented 9 months ago

@jkuester #138 fixes the textColor of the SwitchCompat buttons. This should also be applied in the new screens here. Should a new PR be created?

go ahead and make a new one, you'll probably get it done before one of us would.

neshant commented 8 months ago

This is super cool ! when will this change be released on fdroid to use or how can I already use this , so excited about this change ! <3

I tried using this apk in the master release pipeline however I was not able to install this on my phone,
https://github.com/jkuester/unlauncher/actions/runs/7364754669 I did not see anything significantly different between the Master and Release pipeline that will not allow me to install this .apk from master build. Please advise.

TobiTenno commented 8 months ago

if you're running the fdroid build right now, you can't update with the self-signed one from the repo build. you'd have to uninstall your current local copy before you install the self-signed github one. (this is standard android behavior, not something specific to unlauncher)

jkuester commented 8 months ago

when will this change be released on fdroid

There is not a hard date, but we are hoping to have a beta release released within days and a formal 2.1.0 release cut within a few weeks. Normally, these releases will show up on the F-Droid repo 2-5 days after we cut them here on GitHub.

neshant commented 8 months ago

if you're running the fdroid build right now, you can't update with the self-signed one from the repo build. you'd have to uninstall your current local copy before you install the self-signed github one. (this is standard android behavior, not something specific to unlauncher)

oh thank you so much I am not familiar with android apps signing process, after uninstalling the app I downloaded from fdroid I was able to install this apk which is self signed, thank you so much for explaining this.