jkuester / unlauncher

Android minimalistic launcher
https://jkuester.github.io/unlauncher/
MIT License
305 stars 47 forks source link

Notify when cannot unintall app #190

Closed jkuester closed 8 months ago

jkuester commented 8 months ago

When trying to uninstall a system app from the drawer via the long-press menu, the uninstall will fail, but the user will not be notified in any way.

It would be nice to pop a notification saying the uninstall had failed.

https://github.com/jkuester/unlauncher/blob/d9518e8b861239da8a14e5a2dab417dce097abfa/app/src/main/java/com/sduduzog/slimlauncher/ui/main/HomeFragment.kt#L378C17-L378C17

hayribakici commented 8 months ago

What if the uninstall menu is just disabled or hidden?

jkuester commented 8 months ago

So, some bad QA on my part :facepalm: When I tested this again, I realized that a system notification did get popped indicating that the uninstall failed....

That being said, you are right that it would be a way better UX to just not show the option at all!