search

jkuhl-uni / git-annex-remote-zenodo

Use Zenodo as a special remote for git-annex
GNU General Public License v3.0
0 stars 1 forks source link

Reintroduce key parameter to transfer_store #1

Closed adswa closed 2 months ago

adswa commented 2 months ago

It was, maybe accidentally, removed in 117f4e4, but the annex-remote package relies on passing the key parameter to transfer_store. See https://github.com/Lykos153/AnnexRemote/blob/309f619e2f533373280fb9aa6cac45cbc1ee4842/annexremote/annexremote.py#L613 for the code, and below for the traceback:

[2024-08-19 11:15:42.307829165] (Remote.External)   File "/home/adina/env/datalad/lib/python3.12/site-packages/annexremote/annexremote.py", line 613, in do_TRANSFER
[2024-08-19 11:15:42.307945204] (Annex.ExternalAddonProcess) /home/adina/repos/git-annex-remote-zenodo/git-annex-remote-zenodo[1] --> DEBUG     func(key, file_)
[2024-08-19 11:15:42.308060474] (Remote.External)     func(key, file_)
[2024-08-19 11:15:42.308162839] (Annex.ExternalAddonProcess) /home/adina/repos/git-annex-remote-zenodo/git-annex-remote-zenodo[1] --> DEBUG TypeError: ZenodoRemote.transfer_store() takes 2 positional arguments but 3 were given
jkuhl-uni commented 2 months ago

Hey, I didn't see that. The parameter is not needed in the implementation, that was the reason I took it out. In this case, we can, of course, reintroduce it. Thanks for making me aware :)