jkuhlmann / cgltf

:diamond_shape_with_a_dot_inside: Single-file glTF 2.0 loader and writer written in C99
MIT License
1.46k stars 136 forks source link

missing transmission term #123

Closed seanbaxter closed 4 years ago

seanbaxter commented 4 years ago

cgltf_transmission is missing the refraction term "ior."

https://github.com/KhronosGroup/glTF/blob/d3068171cc56a97b2fc488f407636b8d818d336f/extensions/2.0/Vendor/ADOBE_materials_thin_transparency/README.md#properties

prideout commented 4 years ago

I don't understand; cgltf does not support that particular ADOBE extension. Note however that it supports KHR_materials_transmission, and that KHR_materials_ior is on the way via PR 122.

seanbaxter commented 4 years ago

KHR_materials_transmission isn't in the glTF repository. I didn't know that existed and thought the transmission stuff was the ADOBE extension, which is in the repo. Sorry.

prideout commented 4 years ago

No worries. KHR_materials_transmission is part of the "PBR next" effort that the glTF specifiers are working on. It is already supported by Babylon, and ThreeJS and Filament.