search

jkuhlmann / cgltf

:diamond_shape_with_a_dot_inside: Single-file glTF 2.0 loader and writer written in C99
MIT License
1.44k stars 136 forks source link

Fixes #162 #164

Closed michal-z closed 2 years ago

michal-z commented 2 years ago

162

zeux commented 2 years ago

Out of curiosity, does zig cc not use ming64 includes? MinGW64 should be compatible with MSVC CRT, as such I'd expect it to expose fseeki64, see https://github.com/Alexpux/mingw-w64/blob/master/mingw-w64-crt/stdio/fseeko64.c#L133

michal-z commented 2 years ago

Yes, zig cc uses mingw64. But, it looks like zig version of the fseeko64.c file does not contain _ftell64i function. See: https://github.com/ziglang/zig/blob/master/lib/libc/mingw/stdio/fseeko64.c

zeux commented 2 years ago

Interesting, so their version has some parts of the library that are normally unique to MSVC CRT, but missing this one specifically. Thanks!

michal-z commented 2 years ago

@zeux In mingw-w64 9.0.0 (latest) implementation of _ftelli64 has been moved to fseeki64.c file. But, zig does not include this file at all. Will raise this issue on zig website, thanks for looking at it!

michal-z commented 2 years ago

I have submitted a PR to Zig which adds those functions. See: https://github.com/ziglang/zig/pull/9766

So, I guess we can close this PR.