jkuhlmann / cgltf

:diamond_shape_with_a_dot_inside: Single-file glTF 2.0 loader and writer written in C99
MIT License
1.44k stars 136 forks source link

cgltf_light extras are not ignored on writing anymore #196

Closed sultim-t closed 1 year ago

sultim-t commented 1 year ago

Fixes #195

jkuhlmann commented 1 year ago

Thanks for the PR! As per the build, there seems to be a memory leak. Could you please take a look at that?

zeux commented 1 year ago

I think the build issue is unrelated, and due to the CI using a later snapshot of glTF-Sample-Models which contains additional models that haven't been tested before. I'll take a look and submit a separate PR with a fix.

update see https://github.com/jkuhlmann/cgltf/pull/198