search

jkuri / angular-rollup-starter

Angular2 & Rollup.js including AoT and Universal Prerendering
MIT License
32 stars 9 forks source link

Error headling #5

Closed tamascsaba closed 7 years ago

tamascsaba commented 7 years ago

Rollup build does not handle error, if i misspell something, build also successful a good example: app.component.ts

import { wrongComponent } from '@angular/core';
import * as rx from 'rxjs';
import * as moment from 'moment';

missingglobal.init('');

console.loggggg(rx, moment);

@Component({
  selector: 'app-root',
  templateUrl: 'app.component.html'
})
export class AppComponent {
  title = 'app works!';
}
[BS] File changed: dist/main.js.map
[BS] File changed: dist/main.js
Build time (main): 2799ms
tamascsaba commented 7 years ago

@jkuri ??

jkuri commented 7 years ago

hey @tamascsaba thanks for notice, I think that worked for me but really I need to check and make a fix asap. I hope that'll happen today.

tamascsaba commented 7 years ago

awesome :+1:

jkuri commented 7 years ago

Hi @tamascsaba, sorry for late response. This should be resolved with https://github.com/jkuri/angular2-rollup-starter/commit/9afbd6cf09bbb3b3d9d7c94264fbd146144d690b.