search

jkuri / bore

Reverse HTTP/TCP proxy to help you expose a local server behind a NAT or firewall to the internet via secure SSH tunnels.
https://bore.digital
MIT License
84 stars 8 forks source link

Incomplete error handling #24

Closed dstd closed 2 years ago

dstd commented 2 years ago

I suppose there is a dangling error case – it is handled, but the control flow continues as if there was no error, resulting to a nil pointer dereference.

https://github.com/jkuri/bore/blob/master/server/ssh.go#L202

But I'm not sure what is the right way to fix it – continue or break

jkuri commented 2 years ago

you are right, it is continue. can you please open a pr for that?

jkuri commented 2 years ago

thanks. next time you can add (closes #24) in commit message atthe end and issue is closed automatically, just for your info, its handy.

On Wed, 19 Oct 2022 at 19:48, Denis Stanishevsky @.***> wrote:

Closed #24 https://github.com/jkuri/bore/issues/24 as completed.

— Reply to this email directly, view it on GitHub https://github.com/jkuri/bore/issues/24#event-7624050846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANWPNXAMX5DHOCTFBK7U4TWEAX73ANCNFSM6AAAAAARJK56GM . You are receiving this because you commented.Message ID: @.***>