search

jkusa / ember-cli-clipboard

A simple ember wrapper around clipboard.js
https://jkusa.github.io/ember-cli-clipboard
MIT License
73 stars 33 forks source link

ember modifier v4 #391

Closed jkusa closed 1 year ago

jkusa commented 1 year ago

resolves #390

miguelcobain commented 1 year ago

Ideally, we would use a macro like this to support both versions of ember-modifiers: https://github.com/DockYard/ember-in-viewport/blob/master/addon/modifiers/in-viewport.js#L14

MelSumner commented 1 year ago

This would resolve the deprecation message in the console when using the current version of the addon, yes?

(creating a function-based modifier with { eager: true } is deprecated and will be removed at v4.0 [deprecation id: ember-modifier.function-based-options] This will be removed in ember-modifier 4.0.0.)