search

jkutner / guard-jruby-rspec

RSpec on JRuby without the startup cost.
MIT License
62 stars 16 forks source link

Specs not seeing fixes after first failure #30

Closed ruprict closed 11 years ago

ruprict commented 11 years ago

We are seeing an issue where once a spec fails, it never shows as fixed, even after the fix is in place. Only restarting the guard process reloads the files.

We have tried a bunch of things to fix it (like keep_failed = false) and changing various watchers, but to no avail.

I have created a simple Rails app that shows the issue here. If you start guard and open the app/models/person.rb, the comments in there show how to get it to fail, then fix it. Once it fails, the fix is not reflected by guard until you restart the process.

I am prepared to be doing something wrong/dumb, but we've spent a couple of days trying to get this to work. This gem makes testing so fast that we are desperate to make it work.

We are using JRuby 1.7.4 and Rails 3.2.13

nilbus commented 11 years ago

It's because the old specs are never getting cleared out. You'll notice the number of specs increasing on every run. I have a fix for this I'll be submitting later today.

jkutner commented 11 years ago

That's great @nilbus! I'll get it merged in as soon as you can submit it. I'll try to get a new version released too.

ruprict commented 11 years ago

@nilbus, you are, how-you-say, superfantastic! (So are you, @jkutner...this gem is good stuff) I can test the fix the minute you get it merged.....

Thanks!

jkutner commented 11 years ago

@ruprict can you confirm that this is fixed in the master branch?

ruprict commented 11 years ago

Yes! Works in my little test app and our "real" app. YAAAAAAAAY! YAY