jkutner / guard-jruby-rspec

RSpec on JRuby without the startup cost.
MIT License
62 stars 16 forks source link

RSpec 3 support via guard-rspec-1.x #40

Closed nilbus closed 9 years ago

nilbus commented 9 years ago

Until #38 is implemented for guard-rspec 5.x / guard 2.x compatibility, we're stuck with guard-rspec < 4.0. guard-rspec 1.x is the only version in this range that does not have a runtime dependency on rspec 2. guard-rspec 2.0.0 introduced a runtime dependency on rspec 2 when it started using RSpec's options parser.

In addition, guard-rspec-2.0.0 changed Guard::RSpec::Formatter from a module to a class. guard-jruby-rspec addressed that change in 5f8ec60a6c9237ae216119e0542941a1bc79c82b but did not update its gem dependency to exclude guard-rspec < 2.0.0 as a compatible version, nor did it continue to support the old version, where it was a module. I fixed this in 64a04f9, now in master.

My goal is to support both guard-rspec versions 1-3, as the gemspec reports to. Then bundler can resolve guard-rspec 1 + rspec 3 or guard-rspec 2/3 + rspec 2.

nilbus commented 9 years ago

Tested working with:

Test pending with:

nilbus commented 9 years ago

Confirmed working with:

Merging this into master.

nilbus commented 9 years ago

@jkutner I prepped a 0.2.2 release. Would you like to review and do a new tag and rubygems release?

jkutner commented 9 years ago

Will do!

On Fri, Feb 6, 2015 at 6:09 PM, Edward Anderson notifications@github.com wrote:

@jkutner I prepped a 0.2.2 release. Would you like to review and do a new tag and rubygems release?

Reply to this email directly or view it on GitHub: https://github.com/jkutner/guard-jruby-rspec/pull/40#issuecomment-73337010

swistaczek commented 9 years ago

Great work @nilbus! @jkutner could you please push update to rubygems :)?

jkutner commented 9 years ago

Done https://rubygems.org/gems/guard-jruby-rspec/versions/0.2.2

swistaczek commented 9 years ago

Thanks you very much @jkutner :smile:.