Visual filters displayed in camera view - and not cleared in certain situations

[mrandt]

I like that the visual filters are also applied to the camera display when they are used (e.g. when homing).

In many situations they are not automatically cleared again though, which makes using the camera difficult.

Examples:

• Component hole detection - filters stay on for component pickup
• Failed homing - filters stay on

In addition, I think that it would be nice if one could enable / disable the filter preview and thus always display the original, unmodified camera image - while previewing the filters helps during debugging.

[thethereza]

plan is to do a picture in picture where you can see it with the filters and without. i find using filters all the time essential to debugging problems.

keep adding to the list of times it doesn't turn off and i'll address them at once when they are mostly all identified.

[mrandt]

I also think the filter display is useful for debugging machine operation. But once it works, I would like the ability to turn it off. Pic in pic sounds great - maybe also an option to disable if not needed?

Most noticeable situation when filter display is not cleared is component handling - hence Tape Positions tab. If I click go to next, filter is applied to detect sprocket hole and then stays on forever.

[mrandt]

In many situations this seems fixed in Relase 18.

One occasion in which it still happens can be reproduced as follows (tested on SVN Release 18):

1. add a tape position
2. take photo of component / add template image
3. calibrate tape using part / template image
4. execute "go to next component" function

-> hole detection filter is applied and stays on

For components calibrated using sprocket holes, filter is enabled and disabled correctly.

[thethereza]

Was hole calibration applied before part based template calibration? No filter should be applied when it's doing that unless they also have hole information from some previous configuration perhaps.

On Jul 16, 2015, at 8:26 AM, mrandt notifications@github.com wrote:

In many situations this seems fixed in Relase 18.

One occasion in which it still happens can be reproduced as follows (tested on SVN Release 18):

add a tape position take photo of component / add template image calibrate tape using part / template image execute "go to next component" function -> hole detection filter is applied and stays on

For components calibrated using sprocket holes, filter is enabled and disabled correctly.

— Reply to this email directly or view it on GitHub.

[mrandt]

That might be the case, yes.

I think I tested "hole calibration" first on all my tapes and then moved on to "template / image" based afterwards.

Might be a realistic scenario, isn't it?

[thethereza]

I should delete hole into if you apply a part calibration.

On Thursday, July 16, 2015, mrandt notifications@github.com wrote:

That might be the case, yes.

I think I tested "hole calibration" first on all my tapes and then moved on to "template / image" based afterwards.

Might be a realistic scenario, isn't it?

— Reply to this email directly or view it on GitHub https://github.com/jkuusama/LitePlacer-ver2/issues/2#issuecomment-122020206 .

-Reza

[mrandt]

Good. Let me know when it's in and I'll retest and close.