search

jkvargas / russimp-sys

Assimp raw bindings
Other
2 stars 22 forks source link

feat: prebuilt #26

Closed EYHN closed 2 years ago

EYHN commented 2 years ago

close #25

This pr adds prebuilt feature to russimp-sys, When the prebuilt feature is enabled russimp-sys will not depend on the system wide assimp installation, at the cost of a larger compiled executable. Please see the changed readme file for details.

Prebuilt results can be viewed here https://github.com/EYHN/russimp-sys/actions/runs/1908424353 https://github.com/EYHN/russimp-sys/releases

TODO

test:

Maintenance Guide

!!! The new action requires a secret named ACCESS_TOKEN with a personal access token with repo scopes access, created from here https://github.com/settings/tokens/new

When releasing a version, first change the version in Cargo.toml.

Then use git to create a tag with the version number, action will run to compile pre-built packages for each platform and upload them to github releases.

git tag v1.0.1
git push origin v1.0.1

Releases are saved as drafts so no one else can see them, so don't forget to click publish release when you're done.

Then manually publish to crates.io. Publishing is irreversible, so I think it's better to do it manually.

EYHN commented 2 years ago

image

I have tested it works fine on windows

jkvargas commented 2 years ago

hey man, Is it possible to have static link as an option? I guess would be nice to have the user to decide if he wants to use the library statically linked with prebuilt assimp or use the one available on his own system. Regarding 5.2.2, I am not sure if it breaks user space. Anyways, on russimp side I increase its version everytime russimp-sys is modified.

EYHN commented 2 years ago

Yes, man. I agree that it makes sense to provide an option here. So by default should we use static links or system libraries, you decide?

jkvargas commented 2 years ago

hey man, sorry for the delay answering you. Lets make system libraries by default. Since this is the current default.

EYHN commented 2 years ago

https://github.com/jkvargas/russimp-sys/pull/26/files#diff-d0d98998092552a1d3259338c2c71e118a5b8343dd4703c0c7f552ada7f9cb42R348-R352

Please take a look at the latest changes, uses the system assimp library by default

jkvargas commented 2 years ago

thanks for the contribution bud. Soon as I leave the office, Today, I will review it :)

jkvargas commented 2 years ago

hey bud, I didn't forget your PR. I am moving to a new house, as soon as I get that sorted Ill come back to this :)