search

jkvargas / russimp

Assimp bindings for Rust
Other
84 stars 27 forks source link

Typo in postprocessing enum variant #20

Closed davidepi closed 2 years ago

davidepi commented 2 years ago

In the PostProcessing enum, in the scene.rs file at line 302 the variant GenerateUVCoords is mispelled as GenenerateUVCoords

Unfortunately you just released 1.0 and renaming the variant is a breaking change. Probably deprecating the current one and adding a new variant with the correct name is the best option right now.

jkvargas commented 2 years ago

Thanks for letting me know, mate. Pipelines are executing right now for version 1.0.1 with the fix. :)

jkvargas commented 2 years ago

let me know if you have any problems with 1.0.1

davidepi commented 2 years ago

Everything was fine, tried both on linux with assimp built from source and on macOS with the brew version.

Thanks!