search

jkvargas / russimp

Assimp bindings for Rust
Other
84 stars 27 forks source link

Add clone to some types #28

Closed FredrikNoren closed 1 year ago

FredrikNoren commented 1 year ago

I'm working in a multi-threaded environment, which russimp currently doesn't support in full. To make it possible to at least load textures async I made the materials stuff cloneable, so that I can work with that in an async context.

Would be great if the entire library could be async friendly though (i.e. getting rid of Rc and RefCell). I would suggest flattening the node graph (i.e. scene.nodes: HashMap<.., Node>), to make it possible for it to be both editable and Send + Sync (async friendly)

jkvargas commented 1 year ago

thanks so much for your help, mate. Would you mind to raise the version in Cargo.toml? =)

jkvargas commented 1 year ago

Would be great if the entire library could be async friendly though (i.e. getting rid of Rc and RefCell). I would suggest flattening the node graph (i.e. scene.nodes: HashMap<.., Node>), to make it possible for it to be both editable and Send + Sync (async friendly)

I am not actively working on the library right now, but if you find some type to add that for us I will be very gratefull.

jkvargas commented 1 year ago

I will merge your content and handle the errors on windows.