jkvargas / russimp

Assimp bindings for Rust
Other
84 stars 27 forks source link

Unsound usages of unsafe implementation from `data` to `f64` #68

Open llooFlashooll opened 2 months ago

llooFlashooll commented 2 months ago

Hi, I am scanning the russimp in the latest version with my own static analyzer tool.

Unsafe conversion found at: src/metadata.rs#L93

    fn cast(&self) -> Russult<MetadataType> {
        let raw = self.data.mData as *mut f64;

This unsound implementation would create a misalignment issues if the type size of data is smaller than the type size of f64.

This would potentially cause undefined behaviors in Rust. If we further manipulate the problematic converted types, it would potentially lead to different consequences such as access out-of-bound. I am reporting this issue for your attention.