jkwill87 / mnamer

media file renaming and organizing tool
https://pypi.org/project/mnamer
MIT License
806 stars 68 forks source link

Rename directory? #162

Open rasmus-kirk opened 3 years ago

rasmus-kirk commented 3 years ago

There doesn't seem to be a way to copy/rename a directory (not just the individual files of said directory). Any hope of this seeing support? I have no idea how difficult this would be to implement though.

jkwill87 commented 3 years ago

mnamer does not and will not rename or move directories themselves. This is intentional and not something that will be supported. To clarify, mnamer can create and move media files into subdirectories, just won't move the original one. It's not clear how this would even work -- what happens to files and subdirectories that don't match or if there are multiple different matches in the same directory? It also opens up a bunch of other possible problems like users unintentionally moving their entire downloads folder or the application failing because they are trying to move their current working directory.

Generally speaking, my philosophy in developing user-facing applications is to prioritizing not doing the wrong thing over doing the right thing. You can always delete the source directory after moving files but can't undelete it if it doesn't work as intended.

wellloaded commented 1 year ago

It's a shame that this is not considered. My library works exactly a per request and as i understand so the library of many other users. It is a common approach to leave the files untouched and apply a renaming criteria to the containing folder.

Would it really be that difficult to rename the parent folder based on media content? I don't want to sound pushy at all but is there any chance for this to be reconsidered? Thanks

OdinVex commented 1 year ago

I think a flag requiring maybe a long sentence like --renameparentfoldersacceptingdamage would be a compromise, at least. I'll just write a bash script to do it, for now. Beats fixing about 1400 folder names by hand.

omnigenous commented 1 month ago

@OdinVex Could you share your script?

OdinVex commented 1 month ago

@OdinVex Could you share your script?

Sorry, once I fixed my entire library I didn't need it and trashed the script. :/

Edit: It was simple, if I recall. I did a recursive find for video files and simply got the parent folder name from the filename and did a copy to a new target directory (since I don't like to modify in-place with stuff like this).