reqWrapper as Readable stream

jkyberneees / low-http-server

HTTP Server implementation in top of uWebSocket.js

MIT License

50 stars 7 forks source link

reqWrapper as Readable stream #3

Closed schamberg97 closed 4 years ago

schamberg97 commented 4 years ago

This is a breaking change that reimplements the reqWrapper as a Readable stream. The wrapper creates empty req.body object, BUT no longer deals with populating it. Native HTTP module also does not populate req.body by default.

schamberg97 commented 4 years ago

Additionally, I have removed a check that request body is not processed on GET methods. While this is contrary to the standards, sometimes request bodies are erroneously sent with GET requests. I do not have a strong opinion on this matter, so feel free to revert that change

jkyberneees commented 4 years ago

LGTM !!!