search

jkyberneees / low-http-server

HTTP Server implementation in top of uWebSocket.js
MIT License
50 stars 7 forks source link

Node 10 can't find module worker_threads #8

Closed herudi closed 3 years ago

herudi commented 3 years ago

Low http server is amazing based on uWS. . this is soo fast... but i'm try in node 10, i'm getting error can't find module worker_threads. need --experimental-worker just can. Maybe https://github.com/jkyberneees/low-http-server/blob/master/src/utils/os-compat-check.js.

Thanks ...

schamberg97 commented 3 years ago

You are indeed correct in identifying the issue, I'll fix it today. However, I am not certain I can npm publish the new version

schamberg97 commented 3 years ago

@herudi the issue is fixed in the master branch, however, I do not have the permissions to publish. Perhaps @jkyberneees could do it later? Meanwhile, you can get the package directly from git

jkyberneees commented 3 years ago

Thanks @schamberg97 will review and release ASAP

schamberg97 commented 3 years ago

@jkyberneees don't rush, there are some more changes coming. Also, perhaps it would make sense to grant me the ability to npm publish at some later stage, if you are comfortable with it, so I can deal with the more trivial of issues.

jkyberneees commented 3 years ago

Hi @schamberg97 @herudi, fix is now available in v2.1.2

Great work @schamberg97!

jkyberneees commented 3 years ago

@jkyberneees don't rush, there are some more changes coming. Also, perhaps it would make sense to grant me the ability to npm publish at some later stage, if you are comfortable with it, so I can deal with the more trivial of issues.

Hey @schamberg97 sounds great, could you please drop me an email: kyberneees@gmail.com ?

herudi commented 3 years ago

@jkyberneees @schamberg97 so great ... thanks for fixing my problem...