jl15988 / joplin-plugin-code-perfect

Make your code blocks look perfect!
MIT License
7 stars 1 forks source link

Issue with line numbers and padding #1

Open dsouzadrian opened 4 months ago

dsouzadrian commented 4 months ago

Hi,

Thanks for the plugin, I really like the way it displays code blocks in a rounded cornered black background. Looks awesome on a white theme.

I've run into a few issues however:

  1. The line numbers are off - they don't always sync up to each line of code.
  2. IF the code block is longer - there is an unnecessary scroll bar created and the line number run a lot longer than actual code in the block.
  3. The padding is off between the code text and the line that separates the line numbers

Would you be able to include an option to turn off line numbers completely - give the user the choice if they'd like to see it or not.

Attached below is an image of some of the issues described above.

image

jl15988 commented 4 months ago

Thank you for your question. I will fix it as soon as possible and improve some features.

---Original--- From: "Adrian @.> Date: Wed, Apr 10, 2024 23:16 PM To: @.>; Cc: @.***>; Subject: [jl15988/joplin-plugin-code-perfect] Issue with line numbers andpadding (Issue #1)

Hi,

Thanks for the plugin, I really like the way it displays code blocks in a rounded cornered black background. Looks awesome on a white theme.

I've run into a few issues however:

The line numbers are off - they don't always sync up to each line of code.

IF the code block is longer - there is an unnecessary scroll bar created and the line number run a lot longer than actual code in the block.

The padding is off between the code text and the line that separates the line numbers

Would you be able to include an option to turn off line numbers completely - give the user the choice if they'd like to see it or not.

Attached below is an image of some of the issues described above.

image.png (view on web)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

jl15988 commented 4 months ago

Do you have any other plugins installed, if so please provide the plugin name to help me troubleshoot the problem, thanks! @dsouzadrian

dsouzadrian commented 4 months ago

Yep, I have quite a few others installed.

image

dsouzadrian commented 4 months ago

As a workaround for now - I've disabled line numbers by adding the following to my custom CSS

/* CodePerfect Plugin - disable line numbers*/
.hljs-line-num
{
    display: none !important;
}