jl777 / coins

coin parameters and all files needed for GUI support
39 stars 200 forks source link

Many of the `etomic` addresses are invalid #332

Closed sindresorhus closed 5 years ago

sindresorhus commented 5 years ago

They are in lowercase-only format, which means they're not checksummed, but mm2 requires checksummed smart contract addresses.

For example:

https://github.com/jl777/coins/blob/4ecd07f4991ce27eb067e3a025fc2fd593ea7f0f/coins#L1052

Should be:

0xBd9c6028e1132A6B52F1ca15C0933A2FD342E21f

Someone needs to go through and update all the etomic addresses to be the actual contract address found here: https://etherscan.io/address/0xbd9c6028e1132a6b52f1ca15c0933a2fd342e21f

I think it should also be made clearer in the readme that it should not be the lowercase-only version of the address. It's an easy mistake to make.