search

jl777 / coins

coin parameters and all files needed for GUI support
39 stars 200 forks source link

update required confirmations #424

Closed cipig closed 4 years ago

cipig commented 4 years ago
cipig commented 4 years ago 
Binance, Coinex, Crex24
BTC    1   1   1
BCH    2   1   2
AXE           65
DASH  10   1   6
DGB       10  15
DOGE   2   3   6
ECA          125
ETH   12  12  12
FTC          125
LTC    4   1   4
NAV   20     250
QTUM   6   1  65
RVN   60  10
ZEC   12   1   8

but problem is that you can't do 100 confs for any coin, since that would take hours so i took that into account, crypto51 too and did test swaps to keep the time of one "wait-for-confs"-step under 10 minutes, preferably 5 minutes, so that a swap takes max. 10-20 minutes but it is only a first attempt, so changes/suggestions/discussions are welcome we just need to use the new requires_notarization setting before updating mm2, because keeping the current setting and updating mm2 will disable all notarization requirements i think the most problematic coins atm are AXE, ECA and FTC... not sure how we should deal with masternode-coins... does it offer any bit of additional security regarding 51%-attacks? Or should we deal with them like with any other PoW-coin?

jl777 commented 4 years ago

is this ready to merge?

ca333 commented 4 years ago 

i think the most problematic coins atm are AXE, ECA and FTC... not 
sure how we should deal with masternode-coins... does it offer any 
bit of additional security regarding 51%-attacks? Or 
should we deal with them like with any other PoW-coin?

$24/h for a 51% attack (X11) is very cheap - is AXE aware? It is "just" a $2,640,613 marketcap but we should either remove or tag these "dangerous" coins so users are aware - i believe this is something we could set in the GUI.

@cipig can you plz add a warning into this repos README.md that some coins supported are vulnerable to 51%/double-spend attacks (something that is specific to these blockchains) and just ref. to http://crypto51.app. In the GUIs we will use higher confs for these coins and add a red "51%" warning tag.

cipig commented 4 years ago

@ca333 added a warning regarding 51% attacks and also linked an article i found on our website, it documents some past events. Please make PRs to this repo with updated values, so we have the info in one place.