sapling zaddrs do not work in regtest

jl777 / komodo

Komodo

https://komodoplatform.com/

Other

117 stars 108 forks source link

sapling zaddrs do not work in regtest #1247

Open leto opened 5 years ago

leto commented 5 years ago

Test suite code such as rpc.z_sendmany( taddr, recipients, minconf)

generates:

JSONRPC error: Invalid parameter, unknown address format: zregtestsapling1mwmz8tlx3xvdq4zjwc9sfe0hsrzn440755h2329yxzygxpal472v3k0uwdeteepdj4z6wwa38un

IsValidPaymentAddress() returns false, which causes this exception to be thrown. Currently this blocks fully testing changes in my dpowminconfs branch

leto commented 5 years ago

FYI this no longer blocks merging dpowminconfs, it's merged and I manually tested it

jl777 commented 5 years ago

ok, so we can close this issue?

leto commented 5 years ago

@jl777 no, we still have a bug in regtest, because we didn't pull in some code that understands that regtest sapling addresses have a different bech32 prefix in regtest, which means we can't run a test for anything involving a zaddr in regtest currently