jlab-sensing / soil-power-sensor-firmware

Firmware for STM32 and ESP32 microcontrollers on the Soil Power Sensor board

MIT License

0 stars 3 forks source link

47 hardware implementation sdi12 #65

Closed stevegtaylor closed 2 months ago

stevegtaylor commented 2 months ago

name: SDI-12 Pull Request about: Review some design decisions in SDI-12 library assignees: @stevegtaylor reviewers: @jmadden173

General Design Review of SDI-12 before further integration

47

I would like to review the SDI-12 before the final implantation.

Closes #47

jmadden173 commented 2 months ago

In future PRs can you add more description to the implementation details and follow the PR template where applicable. There's also no comments in the issue either. It also helps to use closing keywords with the issue to ensure the issue gets closed on merge and provide a link to the original issue.

stevegtaylor commented 2 months ago

added changes see commit d5bad87961af6ebd8a132fe540d2acf1a0a41707

Still having initialization issues with the RTC, I'm hoping a merge with @jmadden173's #67 will resolve the initialization issues.

jmadden173 commented 2 months ago

Hmm, I'm wondering whats causing these RTC issues. This seems to be a recurring problem.

John On Thursday, April 18th, 2024 at 10:04 AM, Stephen Taylor @.***> wrote:

added changes see commit d5bad87

Still having initialization issues with the RTC, I'm hoping a merge with @.***(https://github.com/jmadden173)'s #67 will resolve the initialization issues.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>