search

jlab-sensing / soil-power-sensor-firmware

Firmware for STM32 and ESP32 microcontrollers on the Soil Power Sensor board
MIT License
0 stars 3 forks source link

Fixing current adc (Please just approve this) #71

Closed stevegtaylor closed 2 months ago

stevegtaylor commented 2 months ago

name: Integrating improved ads functions for the phytos library

reviewers: 'jmadden173'

I need access to the improved adc functions I created a new branch for integrating the phytos sensors of the main branch per the new protocol, but I don't have access to the changes I made when I fixed the current measurement on this branch. I'm concerned about merge errors in the future.

Development Environment N/A

Test Procedure N/A

Additional Context N/A

jmadden173 commented 2 months ago

What happened to the other PR?

stevegtaylor commented 2 months ago

what other pr?

going to close this one. After some thought to your comments I no longer see it as necessary.

jmadden173 commented 2 months ago

Oh whoops I got this confused with hardware SDI-12. My bad On Thursday, April 18th, 2024 at 2:54 PM, Stephen Taylor @.***> wrote:

what other pr?

going to close this one. After some thought to your comments I no longer see it as necessary.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.Message ID: @.***>