search

jlab-sensing / soil-power-sensor-firmware

Firmware for STM32 and ESP32 microcontrollers on the Soil Power Sensor board
MIT License
0 stars 3 forks source link

45 Fixing current adc #77

Closed stevegtaylor closed 2 months ago

stevegtaylor commented 2 months ago

name: Stephen Taylor about: Implementing Current Readings title: Junior Specialist labels: '' assignees: reviewers: 'jmadden173'

Name/Affiliation/Title Stephen Taylor/UCSC/JS

Purpose of the PR Fixed the timing issues with HAL that prevented current readings. Cleaned up libraries to match style guide.

Development Environment Windows, SPS 2.2

Test Procedure Run the unit test, this should test whether the ADC can even function. Then hook the SPS current and voltage ports and run the 'example_adc' environment to check for reasonable values.

Additional Context N/A

jmadden173 commented 2 months ago

I'm confused, is the PR fixing the current measurements? Or adding calibration files? How do I test it? The build is also failing. Conflicts need to be fixed as well.

stevegtaylor commented 2 months ago

.pio\build\stm32\src\lora_app.o: In functionLoRaWAN_Init': lora_app.c:(.text.LoRaWAN_Init+0xc4): undefined reference to TimeSync' lora_app.c:(.text.LoRaWAN_Init+0xc8): undefined reference toOnTimeSync'`

The build failing is due to the functions you didn't include in user code, this should be resolved upon merge.

stevegtaylor commented 2 months ago

Closes #45