search

jlacko / RCzechia

A package providing Czech shapefiles - LAU & NUTS regions, municipalities, rivers etc. - in R friendly format for analysis & visualization
https://rczechia.jla-data.net
Other
24 stars 6 forks source link

License: JOSS Review #55

Closed nickbearman closed 1 year ago

nickbearman commented 1 year ago

Hi @jlacko You don't have a license file at https://github.com/jlacko/RCzechia/blob/master/LICENSE which we need for the JOSS review. https://github.com/openjournals/joss-reviews/issues/5082 Please do update it when you can. Thanks, Nick.

jlacko commented 1 year ago

The somewhat underwhelming structure of the LICENSE file is a direct consequence of the CRAN interpretation of the MIT license (= declaring MIT in the license field of the package DESCRIPTION file + having a LICENSE file with a year and a name, full stop). This is on one hand non negotiable requirement for a CRAN listing, and on the other hand not in line with GitHub interpretation of the MIT license terms. I have kept the CRAN structure as it is (since deviating would be a reason for delisting) but added a LICENSE.md file that is ignored from package build. This pattern is what usethis::use_mit_license() promotes, and seems to be the current best practice.