jlaksana / UML2Code

UML diagram creator designed for intro CS students
https://uml2code.vercel.app
2 stars 0 forks source link

Edit and delete relationship #44

Closed jlaksana closed 1 year ago

jlaksana commented 1 year ago

Description Create new endpoints to edit and delete relationships.

Acceptance Criteria DELETE relationship/:id

PUT relationship/:id

Additional Information Figure out the best way to initiate editing and deleting an edge.

jlaksana commented 1 year ago

Two possible ways to delete: del button or add to edit modal a trash icon button To edit a relationship, double click on the edge

jlaksana commented 1 year ago

delete relationship: https://github.com/jlaksana/UML2Code/commit/b2ee2381fa1dcf36e22e7d71bdfb72e75c39bf5b

jlaksana commented 1 year ago

Delete edges with "Backspace" key. Will add a delete button to the modal. Nodes will support this as well. Double click an edge to open an edit modal

jlaksana commented 1 year ago

Found a way to create a toolbar just like I did with nodes. Delete has been handled. For edit, we need to do a couple of things. I think there is an advantage to creating a separate endpoint for editing handles of an edge from editing the content of the edge. There are certain validations that need to happen that are unique to either case. We also should make a separate modal for editing relationships because I don't think we should allow a user to change the relationship type after creating it. We should also store the source and target names so that we can access it in the edit modal.

jlaksana commented 1 year ago

https://github.com/jlaksana/UML2Code/commit/8d29c273e83d377370518c3c66b3e37b83ce561a Created a new get endpoint for a single relationship. This is used to populate the edit modal