search

jlam55555 / veikk-linux-driver

Linux driver for VEIKK-brand digitizers
139 stars 33 forks source link

Update v3-alpha Makefile to match fix in commit 815cff1836e031d6d9a6f… #39

Closed sparshjain265 closed 4 years ago

sparshjain265 commented 4 years ago

…a988276d3c449cefe61

jlam55555 commented 4 years ago

@sparshjain265 Thanks for this. Somehow I missed this for so long. Here are some comments:

  1. I'll try to make the same changes to the Makefile as in v2 (and perhaps with this new change)
  2. Try to stick to the kernel coding style. This means things like 8-width tab indenting, no more than 80-width lines, opening braces at the end of a line for deliminating most block bodies except for functions. (It looks like you might've had an IDE auto-format the code, but I'm not sure.)
  3. I'm struggling with the A15 Pro keymap, and it looks like you might be having problems as well. The specific one I'm particularly concerned about is key 5, since it maps to only the control modifier. I'm really interested in what you might be seeing when testing that. (I'd be open to a 1-on-1 live session on that, might be quicker to find out how to deal with it. Email me if you'd like to do that.)

As per these comments, I don't think I'll merge this PR as it is right now.

sparshjain265 commented 4 years ago

@jlam55555 good to hear back from you. To your comments:

  1. The new change looks good, I'll use that as well
  2. I'll read the kernel coding style you mentioned, thanks for the link. Yes, you're right, I use vscode and it autoformats the code for me. I'll change the settings to use 8-width indenting, and make sure I don't use more than 80-width lines, however, I'll have to look through settings to make sure that opening braces style can be managed.
  3. For the A15 Pro keymap, I tried to play with the 'usage_pusage_map', will test more and yes, 1-on-1 live session sounds good too, just a little later (after I've played a bit more)

Also, I'm sorry, I didn't realize what I was doing, I only wished to make the pull request for the commit that made changes to the Makefile, other commits were just me trying to play with the code.