search

jlam55555 / veikk-linux-driver

Linux driver for VEIKK-brand digitizers
139 stars 33 forks source link

add VK640 #63

Open Bloody-Badboy opened 3 years ago

Bloody-Badboy commented 3 years ago

VK640 has tilt functionality extra param added to report

jlam55555 commented 3 years ago

I'll be fine approving this, but I don't know what events have to be emitted (I don't have such a device with tilt support, the older VEIKK devices don't). If I understand correctly, this adds another field to the report struct, but you will have to emit an event to actually implement the support. Let me know if I am understanding incorrectly.

I am also worried that this may cause a minor issue on devices without tilt support, because their report struct is smaller and accessing the bytes afterwards is UB. If you do not end up using the tilt support, I may end up just committing the part adding the VK640 and not the change to the report struct.